test(engine):add DM test case new_collation_off #6857
Conversation
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
added
size/L
Signed-off-by: lance6716 <[email protected]>
|
/cc @GMHDBJD @maxshuang |
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
|
/run-engine-integration-test |
|
/merge |
|
@lance6716: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-engine-integration-test |
2 similar comments
|
/run-engine-integration-test |
|
/run-engine-integration-test |
Signed-off-by: lance6716 <[email protected]>
|
/run-engine-integration-test |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #6857 +/- ##
================================================
- Coverage 59.9224% 59.8670% -0.0555%
================================================
Files 783 786 +3
Lines 89519 89627 +108
================================================
+ Hits 53642 53657 +15
- Misses 31168 31255 +87
- Partials 4709 4715 +6 |
|
/run-engine-integration-test |
| @@ -216,16 +216,18 @@ func (l *LightningLoader) runLightning(ctx context.Context, cfg *lcfg.Config) er | |||
| var opts []lightning.Option | |||
| if l.cfg.MetricsFactory != nil { | |||
| // this branch means dataflow engine has set a Factory, the Factory itself | |||
| // will register and deregister metrics, so we must use NoopRegistry | |||
| // to avoid duplicated registration. | |||
| // will register and deregister metrics, but lightning will expect the | |||
There was a problem hiding this comment.
Do you think we need to add a unregister method to Factory to make it more flexible?
deployments/engine/docker-compose/dm_databases_tidb_new_collation_off.yaml
Show resolved
Hide resolved
…ion_off.yaml Co-authored-by: CharlesCheung <[email protected]>
|
/run-engine-integration-test |
|
Rest LGTM. |
| @@ -0,0 +1,61 @@ | |||
| version: '2.3' | |||
There was a problem hiding this comment.
Better to use a general filename, such as: dm_database_tidb_v6.1.yaml
There was a problem hiding this comment.
new_collation_off is the key difference of this deployment. (I'll change v6.1 to nightly in next commit)
ti-chi-bot
added
status/LGT2
Signed-off-by: lance6716 <[email protected]>
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 83940d4
|
ti-chi-bot
added
the
status/can-merge
|
@lance6716: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-verify |
What problem does this PR solve?
Issue Number: close #6851 ref #6776
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note