Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor panic after task resume #6851

Closed
lance6716 opened this issue Aug 23, 2022 · 3 comments · Fixed by #6857
Closed

executor panic after task resume #6851

lance6716 opened this issue Aug 23, 2022 · 3 comments · Fixed by #6857
Labels
area/engine Issues or PRs related to Dataflow Engine. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@lance6716
Copy link
Contributor

What did you do?

df.log

What did you expect to see?

No response

What did you see instead?

3m3e-server-executor-2               | panic: duplicate metrics collector registration attempted

Versions of the cluster

Dataflow Engine version (run tiflow version):

(paste Dataflow Engine version here)
@lance6716 lance6716 added type/bug The issue is confirmed as a bug. area/engine Issues or PRs related to Dataflow Engine. labels Aug 23, 2022
@maxshuang
Copy link
Contributor

May be it's better to return an registration error instead of making executor panic.
I will fix it later.

@maxshuang
Copy link
Contributor

BTW, business logic should protect its own goroutine to avoid taking down the executor.

@maxshuang
Copy link
Contributor

/cc @maxshuang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issues or PRs related to Dataflow Engine. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants