Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): add transaction-atomicity parameter to SinkURI #6038

Merged
merged 10 commits into from
Jul 1, 2022
Merged

sink(ticdc): add transaction-atomicity parameter to SinkURI #6038

merged 10 commits into from
Jul 1, 2022

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Jun 25, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #5231

What is changed and how it works?

  1. Add transaction-atomicity parameter to SinkURI
  2. Use validateAndAdjust method to parse and verify sinkURI's parameters uniformly.
  3. Add splitTxn field to flowController to accommodate different transaction atomicity.
  4. Add defensive checks in sinkNode.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

Yes

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nongfushanquan
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/ticdc Issues or PRs related to TiCDC. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 25, 2022
@CharlesCheung96 CharlesCheung96 force-pushed the add_split_txn_switcher branch 6 times, most recently from 36481af to 281cd27 Compare June 28, 2022 03:18
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review June 28, 2022 03:53
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2022
@ti-chi-bot ti-chi-bot requested a review from amyangfei June 28, 2022 03:53
@CharlesCheung96 CharlesCheung96 force-pushed the add_split_txn_switcher branch from 281cd27 to 77a9a2d Compare June 28, 2022 09:12
overvenus
overvenus reviewed Jun 28, 2022
View reviewed changes
pkg/config/sink.go Outdated Show resolved Hide resolved
@CharlesCheung96 CharlesCheung96 force-pushed the add_split_txn_switcher branch from f1a047e to 0531ad2 Compare June 29, 2022 02:38
@CharlesCheung96 CharlesCheung96 changed the title sink(ticdc): add split-txn switcher sink(ticdc): add transaction-Atomicity parameter to SinkURI Jun 29, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2022
@CharlesCheung96
Copy link
Contributor Author

/cc asddongmen

@ti-chi-bot ti-chi-bot requested a review from asddongmen July 1, 2022 04:54
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bc03cb1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 1, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-dm-integration-test
/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 0b7969d into pingcap:master Jul 1, 2022
@CharlesCheung96
Copy link
Contributor Author

/label needs-cherry-pick-release-6.1

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jul 1, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-cherry-picker

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 1, 2022
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#6038
57377f2 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 1, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6140.

CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jul 1, 2022
@CharlesCheung96
sink(ticdc): add transaction-atomicity parameter to SinkURI (pingcap#…
dfe1704 
…6038)

ref pingcap#5231
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jul 4, 2022
@CharlesCheung96
sink(ticdc): add transaction-atomicity parameter to SinkURI (pingcap#…
e134e73 
…6038)

ref pingcap#5231
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jul 6, 2022
@CharlesCheung96
sink(ticdc): add transaction-atomicity parameter to SinkURI (pingcap#…
ea4adaf 
…6038)

ref pingcap#5231
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jul 6, 2022
@CharlesCheung96
sink(ticdc): add transaction-atomicity parameter to SinkURI (pingcap#…
1f095a2 
…6038)

ref pingcap#5231
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jul 6, 2022
@CharlesCheung96
sink(ticdc): add transaction-atomicity parameter to SinkURI (pingcap#…
5b94051 
…6038)

ref pingcap#5231
ti-chi-bot added a commit that referenced this pull request Jul 6, 2022
@ti-chi-bot
sink(ticdc): add transaction-atomicity parameter to SinkURI (#6038) (#…
be67a42 
…6140)

ref #5231
@asddongmen asddongmen mentioned this pull request Jul 20, 2022
Closed
This was referenced Aug 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxshuang maxshuang maxshuang left review comments

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen asddongmen approved these changes

@overvenus overvenus overvenus approved these changes

@amyangfei amyangfei Awaiting requested review from amyangfei

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CharlesCheung96 @ti-chi-bot @asddongmen @overvenus @maxshuang @nongfushanquan