Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't not use config file to specify a sink protocol #6360

Closed
asddongmen opened this issue Jul 20, 2022 · 2 comments · Fixed by #6361
Closed

can't not use config file to specify a sink protocol #6360

asddongmen opened this issue Jul 20, 2022 · 2 comments · Fixed by #6361
Labels
area/ticdc Issues or PRs related to TiCDC. component/cli CLI component. severity/minor type/bug The issue is confirmed as a bug.

Comments

@asddongmen
Copy link
Contributor

What did you do?

as title.

What did you expect to see?

No response

What did you see instead?

as title.

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

master
@asddongmen asddongmen added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. component/cli CLI component. labels Jul 20, 2022
@lonng
Copy link
Contributor

lonng commented Jul 20, 2022

Is that a feature or a bug?

@asddongmen asddongmen mentioned this issue Jul 20, 2022
Merged
@asddongmen
Copy link
Contributor Author

asddongmen commented Jul 20, 2022 •
edited
Loading

@lonng
It is a bug introduce by this PR: #6038
Before this PR above, we can specify sink protocol by config file when create a changefeed.

ti-chi-bot pushed a commit that referenced this issue Jul 20, 2022
@asddongmen
config (ticdc): Fix sink protocol can no specify by config file. (#6361)
eb350dc 
close #6360
@ti-chi-bot ti-chi-bot mentioned this issue Nov 1, 2022
Merged
ti-chi-bot added a commit that referenced this issue Nov 4, 2022
@ti-chi-bot
config (ticdc): Fix sink protocol can no specify by config file. (#6361…
9f3c1c8 
…) (#7508)

close #6360, ref #7501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/cli CLI component. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config (ticdc): Fix sink protocol can no specify by config file. asddongmen/tiflow
2 participants
@lonng @asddongmen