-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm-master(dm): use advertise address for ETCD client #4608
Conversation
* Adapt the UTs
* Refactor the test logic
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @lichunzhu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 46e8913
|
/run-verify |
/run-dm-integration-test |
@dsdashun: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request created: #4639. |
In response to a cherrypick label: new pull request created: #4640. |
What problem does this PR solve?
Issue Number: close #4511
What is changed and how it works?
Use the advertise address to places where an ETCD client may be needed. In this PR, when we create an ETCD client, we need to use the advertise address; When we specify the address to join, we actually use the advertise address.
Also the UTs are adapted to the new logic. In the current tests, we set the advertise address and master address the same value so that the server start logic can retrieve the advertise address's value.
What's more, some extra UTs are added to specify the master address as 0.0.0.0:, and set the advertise address to the specific value. Both TLS / non-TLS scenarios are covered.
Check List
Tests
N/A
Side effects
N/A
Related changes
N/A
Release note