Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm-master(dm): use advertise address for ETCD client #4608

Merged
merged 5 commits into from
Feb 21, 2022

Conversation

dsdashun
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4511

What is changed and how it works?

Use the advertise address to places where an ETCD client may be needed. In this PR, when we create an ETCD client, we need to use the advertise address; When we specify the address to join, we actually use the advertise address.

Also the UTs are adapted to the new logic. In the current tests, we set the advertise address and master address the same value so that the server start logic can retrieve the advertise address's value.

What's more, some extra UTs are added to specify the master address as 0.0.0.0:, and set the advertise address to the specific value. Both TLS / non-TLS scenarios are covered.

Check List

Tests

  • Unit test

N/A

Side effects

N/A

Related changes

N/A

Release note

None

* Adapt the UTs
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2022
@dsdashun dsdashun requested a review from lance6716 February 16, 2022 09:10
@dsdashun
Copy link
Contributor Author

/cc @lichunzhu

@ti-chi-bot ti-chi-bot requested a review from lichunzhu February 16, 2022 09:12
@dsdashun dsdashun added the area/dm Issues or PRs related to DM. label Feb 16, 2022
@dsdashun dsdashun changed the title dm-master(dm): fix listen address for DM master dm-master(dm): use advertise address for ETCD client Feb 16, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2022
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 21, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 46e8913

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2022
@dsdashun
Copy link
Contributor Author

/run-verify

@dsdashun
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Feb 21, 2022
@ti-chi-bot
Copy link
Member

@dsdashun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4639.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4640.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maybe adverseAddr should be used in some places insted of masterAddr
4 participants