Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe adverseAddr should be used in some places insted of masterAddr #4511

Closed
nexustar opened this issue Feb 7, 2022 · 0 comments · Fixed by #4608
Closed

maybe adverseAddr should be used in some places insted of masterAddr #4511

nexustar opened this issue Feb 7, 2022 · 0 comments · Fixed by #4608
Assignees
Labels
affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. area/dm Issues or PRs related to DM. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@nexustar
Copy link

nexustar commented Feb 7, 2022

What did you do?

I try to use DM with TLS (with --masterAddr=0.0.0.0:8261), but worker cannot connect to master, master log shows

[grpclog.go:42] ["grpc: addrConn.createTransport failed to connect to {0.0.0.0:8261  <nil> 0 <nil>}. Err: connection error: desc = \"transport: authentication handshake failed: x509: certificate is valid for 127.0.0.1, 192.168.122.25, not 0.0.0.0\". Reconnecting..."] [component="embed etcd"]

It works after I add 0.0.0.0 to alt_names of cert, bit I think it should not be necessary

Then I search the code, I found somewhere, masterAddr was used as endpoint. maybe adverseAddr should be used instead. For example: https://github.com/pingcap/tiflow/blob/master/dm/dm/master/server.go#L214

related issue: pingcap/dm#966

What did you expect to see?

No response

What did you see instead?

No response

Versions of the cluster

v2.0.7 v5.3.0

current status of DM cluster (execute query-status <task-name> in dmctl)

(paste current status of DM cluster here)
@nexustar nexustar added type/bug The issue is confirmed as a bug. area/dm Issues or PRs related to DM. labels Feb 7, 2022
@niubell niubell assigned dsdashun and unassigned lichunzhu Feb 14, 2022
dsdashun added a commit to dsdashun/tiflow that referenced this issue Feb 16, 2022
* Adapt the UTs
@lichunzhu lichunzhu added affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. labels Feb 21, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Feb 21, 2022
* Adapt the UTs
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Feb 21, 2022
* Adapt the UTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. area/dm Issues or PRs related to DM. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants