Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter: refine comments and function visibility (#2308) #2310

Merged
merged 4 commits into from
Jul 21, 2021
Merged

filter: refine comments and function visibility (#2308) #2310

merged 4 commits into from
Jul 21, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2308

What problem does this PR solve?

ref: https://github.com/pingcap/ticdc/pull/2218

What is changed and how it works?

Pick some code from the original PR.

Check List

Tests

  • No code

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2021
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Jul 17, 2021
@ti-chi-bot ti-chi-bot requested review from zier-one and overvenus July 17, 2021 04:04
@amyangfei amyangfei added this to the v4.0.14 milestone Jul 17, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 19, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2021
@amyangfei amyangfei modified the milestones: v4.0.14, v4.0.15 Jul 19, 2021
@amyangfei
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021 •
edited
Loading

Codecov Report

Merging #2310 (220a46c) into release-4.0 (753073a) will increase coverage by 0.9349%.
The diff coverage is 59.5644%.

@@                 Coverage Diff                 @@
##           release-4.0      #2310        +/-   ##
===================================================
+ Coverage      53.7661%   54.7010%   +0.9349%     
===================================================
  Files              153        166        +13     
  Lines            15958      19921      +3963     
===================================================
+ Hits              8580      10897      +2317     
- Misses            6475       7963      +1488     
- Partials           903       1061       +158

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 2817e14

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2021
@Rustin170506
Copy link
Member

/run-unit-tests

/run-integration-tests

@Rustin170506
Copy link
Member

/run-integration-tests

1 similar comment
@Rustin170506
Copy link
Member

/run-integration-tests

@Rustin170506
Copy link
Member

/run-integration-tests

1 similar comment
@Rustin170506
Copy link
Member

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit f620bae into pingcap:release-4.0 Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one Awaiting requested review from zier-one

@overvenus overvenus Awaiting requested review from overvenus

Assignees

@Rustin170506 Rustin170506

Labels
cherry-pick-approved Cherry pick PR approved by release team. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
v4.0.15
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @amyangfei @codecov-commenter @Rustin170506 @lonng