Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter: refine comments and function visibility #2308

Merged
merged 1 commit into from
Jul 17, 2021
Merged

filter: refine comments and function visibility #2308

merged 1 commit into from
Jul 17, 2021

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

ref: https://github.com/pingcap/ticdc/pull/2218

What is changed and how it works?

Pick some code from the original PR.

Check List

Tests

  • No code

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

@ti-chi-bot ti-chi-bot requested review from zier-one and overvenus July 16, 2021 15:58
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 16, 2021
@Rustin170506 Rustin170506 added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. require-LGT1 Indicates that the PR requires an LGTM. labels Jul 16, 2021
@Rustin170506
Copy link
Member Author

Rustin170506 commented Jul 16, 2021 •
edited
Loading

This PR is simple, so I've marked it only need one 👍🏿 .

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7d30fad

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 17, 2021
@Rustin170506
Copy link
Member Author

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit bb23408 into pingcap:master Jul 17, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2310.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2311.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 17, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#2308
779849f 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2312.

ti-chi-bot added a commit that referenced this pull request Jul 19, 2021
@ti-chi-bot
filter: refine comments and function visibility (#2308) (#2311)
e3cf5d1
ti-chi-bot added a commit that referenced this pull request Jul 21, 2021
@ti-chi-bot
filter: refine comments and function visibility (#2308) (#2310)
f620bae
ti-chi-bot added a commit that referenced this pull request Jul 22, 2021
@ti-chi-bot
filter: refine comments and function visibility (#2308) (#2312)
8dc24d8
@Rustin170506 Rustin170506 deleted the rustin-patch-filter branch August 15, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@zier-one zier-one Awaiting requested review from zier-one

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rustin170506 @ti-chi-bot @amyangfei