Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: make error message compatible with pd flag name when PD address unreachable (#2122) #2127

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2122

What problem does this PR solve?

Inaccurate error message for PD address #1893

What is changed and how it works?

as the title said

Check List

Related changes

  • Need to cherry-pick to the release branch

Release note

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Jun 22, 2021
@ti-chi-bot ti-chi-bot requested review from zier-one and overvenus June 22, 2021 09:14
@ti-chi-bot ti-chi-bot requested a review from amyangfei June 22, 2021 09:14
@ti-chi-bot
Copy link
Member Author

@ben1009: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei amyangfei added this to the v4.0.14 milestone Jun 23, 2021
@ben1009
Copy link
Contributor

ben1009 commented Jun 28, 2021

/run-unit-tests

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 6, 2021
@amyangfei amyangfei added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 7, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 85c74d2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 7, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

Codecov Report

Merging #2127 (08367cf) into release-4.0 (753073a) will decrease coverage by 0.0779%.
The diff coverage is 62.2068%.

@@                 Coverage Diff                 @@
##           release-4.0      #2127        +/-   ##
===================================================
- Coverage      53.7661%   53.6882%   -0.0780%     
===================================================
  Files              153        163        +10     
  Lines            15958      17339      +1381     
===================================================
+ Hits              8580       9309       +729     
- Misses            6475       7049       +574     
- Partials           903        981        +78     

@ti-chi-bot ti-chi-bot merged commit fc3415f into pingcap:release-4.0 Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants