-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: make error message compatible with pd flag name when PD address unreachable (#2122) #2127
cli: make error message compatible with pd flag name when PD address unreachable (#2122) #2127
Conversation
@ben1009: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-tests |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 85c74d2
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2127 +/- ##
===================================================
- Coverage 53.7661% 53.6882% -0.0780%
===================================================
Files 153 163 +10
Lines 15958 17339 +1381
===================================================
+ Hits 8580 9309 +729
- Misses 6475 7049 +574
- Partials 903 981 +78 |
This is an automated cherry-pick of #2122
What problem does this PR solve?
Inaccurate error message for PD address #1893
What is changed and how it works?
as the title said
Check List
Related changes
Release note