Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: make error message compatible with pd flag name when PD address unreachable #2122

Merged
merged 2 commits into from
Jun 22, 2021
Merged

cli: make error message compatible with pd flag name when PD address unreachable #2122

merged 2 commits into from
Jun 22, 2021

Conversation

ben1009
Copy link
Contributor

@ben1009 ben1009 commented Jun 22, 2021

What problem does this PR solve?

Inaccurate error message for PD address #1893

What is changed and how it works?

as the title said

Check List

Related changes

  • Need to cherry-pick to the release branch

Release note

@ti-chi-bot ti-chi-bot requested review from zier-one and overvenus June 22, 2021 02:54
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2021
@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. labels Jun 22, 2021
@amyangfei amyangfei added this to the v5.1.1 milestone Jun 22, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4aa456a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2021
@ben1009
Copy link
Contributor Author

ben1009 commented Jun 22, 2021

/run-unit-tests

@ben1009
Copy link
Contributor Author

ben1009 commented Jun 22, 2021

/run-kafka-integration-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit d139b47 into master Jun 22, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 22, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2127.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 22, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2128.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 22, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2129.

@overvenus overvenus deleted the cdc-pd-addr branch June 23, 2021 14:38
@Rustin170506 Rustin170506 mentioned this pull request Jun 24, 2021
Merged
ti-chi-bot added a commit that referenced this pull request Jun 24, 2021
@ti-chi-bot
cli: make error message compatible with pd flag name when PD address …
e66d44c 
…unreachable (#2122) (#2128)
liuzix pushed a commit to liuzix/ticdc that referenced this pull request Jul 6, 2021
@ti-chi-bot @liuzix
cli: make error message compatible with pd flag name when PD address …
8d4e048 
…unreachable (pingcap#2122) (pingcap#2128)
ti-chi-bot added a commit that referenced this pull request Jul 7, 2021
@ti-chi-bot
cli: make error message compatible with pd flag name when PD address …
fc3415f 
…unreachable (#2122) (#2127)
ti-chi-bot added a commit that referenced this pull request Jul 9, 2021
@ti-chi-bot
cli: make error message compatible with pd flag name when PD address …
c698886 
…unreachable (#2122) (#2129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuzix liuzix liuzix approved these changes

@amyangfei amyangfei amyangfei approved these changes

@zier-one zier-one Awaiting requested review from zier-one

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ben1009 @ti-chi-bot @amyangfei @liuzix