Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/config, sink(ticdc): support output raw change event for mq and cloud storage sink #11226

Merged
merged 20 commits into from
Jun 11, 2024
Merged

pkg/config, sink(ticdc): support output raw change event for mq and cloud storage sink #11226

merged 20 commits into from
Jun 11, 2024

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Jun 3, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #11211

What is changed and how it works?

  1. Add output-raw-change-event to KafkaConfig, PulsarConfig and CloudStorageConfig.
  2. When outputRawChangeEvent=true, do not split update in table sink.
  3. Add integration tests to cover the outputRawChangeEvent congiuration.

TODO: Kafka and Pulsar related integration tests will be added in another pull request.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

Yes

Release note 

`support output raw change event for mq and cloud storage sink `.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Jun 3, 2024
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2024
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jun 4, 2024
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review June 4, 2024 16:18
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot removed the approved label Jun 10, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, flowbehappy, kevin-xianliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 11, 2024
@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 3887861 into pingcap:master Jun 11, 2024
28 of 29 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 11, 2024
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11290.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 11, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#11226
fa7cb87 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11291.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 11, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#11226
3446150 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 11, 2024
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11292.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 11, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#11226
a9af136 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Jun 11, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11293.

ti-chi-bot bot pushed a commit that referenced this pull request Jun 11, 2024
@ti-chi-bot
pkg/config, sink(ticdc): support output raw change event for mq and c…
c092599 
…loud storage sink (#11226) (#11290)

close #11211
hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 12, 2024
@hicqu
Squashed commit of the following:
a3d30ca 
commit c092599
Author: Ti Chi Robot <[email protected]>
Date:   Wed Jun 12 00:26:59 2024 +0800

    pkg/config, sink(ticdc): support output raw change event for mq and cloud storage sink (pingcap#11226) (pingcap#11290)

    close pingcap#11211

commit 3426e46
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 19:40:29 2024 +0800

    puller(ticdc): fix wrong update splitting behavior after table scheduling (pingcap#11269) (pingcap#11282)

    close pingcap#11219

commit 2a28078
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 16:40:37 2024 +0800

    mysql(ticdc): remove error filter when check isTiDB in backend init (pingcap#11214) (pingcap#11261)

    close pingcap#11213

commit 2425d54
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 16:40:30 2024 +0800

    log(ticdc): Add more error query information to the returned error to facilitate users to know the cause of the failure (pingcap#10945) (pingcap#11257)

    close pingcap#11254

commit 053cdaf
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 15:34:30 2024 +0800

    cdc: log slow conflict detect every 60s (pingcap#11251) (pingcap#11287)

    close pingcap#11271

commit 327ba7b
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 11:42:00 2024 +0800

    redo(ticdc): return internal error in redo writer (pingcap#11011) (pingcap#11091)

    close pingcap#10124

commit d82ae89
Author: Ti Chi Robot <[email protected]>
Date:   Mon Jun 10 22:28:29 2024 +0800

    ddl_puller (ticdc): handle dorp pk/uk ddl correctly (pingcap#10965) (pingcap#10981)

    close pingcap#10890

commit f15bec9
Author: Ti Chi Robot <[email protected]>
Date:   Fri Jun 7 16:16:28 2024 +0800

    redo(ticdc): enable pprof and set memory limit for redo applier (pingcap#10904) (pingcap#10996)

    close pingcap#10900

commit ba50a0e
Author: Ti Chi Robot <[email protected]>
Date:   Wed Jun 5 19:58:26 2024 +0800

    test(ticdc): enable sequence test (pingcap#11023) (pingcap#11037)

    close pingcap#11015

commit 94b9897
Author: Ti Chi Robot <[email protected]>
Date:   Wed Jun 5 17:08:56 2024 +0800

    mounter(ticdc): timezone fill default value should also consider tz. (pingcap#10932) (pingcap#10946)

    close pingcap#10931

commit a912d33
Author: Ti Chi Robot <[email protected]>
Date:   Wed Jun 5 10:49:25 2024 +0800

    mysql (ticdc): Improve the performance of the mysql sink by refining the transaction event batching logic (pingcap#10466) (pingcap#11242)

    close pingcap#11241

commit 6277d9a
Author: dongmen <[email protected]>
Date:   Wed May 29 20:13:22 2024 +0800

    kvClient (ticdc): revert e5999e3 to remove useless metrics (pingcap#11184)

    close pingcap#11073

commit 54e93ed
Author: dongmen <[email protected]>
Date:   Wed May 29 17:43:22 2024 +0800

    syncpoint (ticdc): make syncpoint support base64 encoded password (pingcap#11162)

    close pingcap#10516

commit 0ba9329
Author: Ti Chi Robot <[email protected]>
Date:   Wed May 29 09:07:21 2024 +0800

    (redo)ticdc: fix the event orderliness in redo log (pingcap#11117) (pingcap#11180)

    close pingcap#11096

Signed-off-by: qupeng <[email protected]>
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jul 15, 2024
@CharlesCheung96
pkg/config, sink(ticdc): support output raw change event for mq and c…
909c001 
…loud storage sink (pingcap#11226)

close pingcap#11211
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jul 15, 2024
@CharlesCheung96
pkg/config, sink(ticdc): support output raw change event for mq and c…
d970f03 
…loud storage sink (pingcap#11226)

close pingcap#11211
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jul 15, 2024
@CharlesCheung96
pkg/config, sink(ticdc): support output raw change event for mq and c…
a77670a 
…loud storage sink (pingcap#11226)

close pingcap#11211
ti-chi-bot bot pushed a commit that referenced this pull request Jul 17, 2024
@ti-chi-bot
pkg/config, sink(ticdc): support output raw change event for mq and c…
6395bdd 
…loud storage sink (#11226) (#11292)

close #11211
ti-chi-bot bot pushed a commit that referenced this pull request Jul 17, 2024
@ti-chi-bot
pkg/config, sink(ticdc): support output raw change event for mq and c…
9e93510 
…loud storage sink (#11226) (#11291)

close #11211
ti-chi-bot bot pushed a commit that referenced this pull request Aug 2, 2024
@ti-chi-bot
pkg/config, sink(ticdc): support output raw change event for mq and c…
6cf7f46 
…loud storage sink (#11226) (#11293)

close #11211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-xianliu kevin-xianliu kevin-xianliu approved these changes

@asddongmen asddongmen asddongmen approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

Assignees
No one assigned
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support output raw change event for mq and cloud storage sink
6 participants
@CharlesCheung96 @ti-chi-bot @flowbehappy @3AceShowHand @asddongmen @kevin-xianliu