Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/config, sink(ticdc): support output raw change event for mq and cloud storage sink (#11226) #11292

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11226

What problem does this PR solve?

Issue Number: close #11211

What is changed and how it works?

  1. Add output-raw-change-event to KafkaConfig, PulsarConfig and CloudStorageConfig.
  2. When outputRawChangeEvent=true, do not split update in table sink.
  3. Add integration tests to cover the outputRawChangeEvent congiuration.

TODO: Kafka and Pulsar related integration tests will be added in another pull request.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

Yes

Release note

`support output raw change event for mq and cloud storage sink `.

@ti-chi-bot ti-chi-bot added affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jun 11, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 13, 2024
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-11226-to-release-7.5 branch from a9af136 to 909c001 Compare July 15, 2024 05:41
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-11226-to-release-7.5 branch from 909c001 to a77670a Compare July 15, 2024 06:17
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 15, 2024
@CharlesCheung96
Copy link
Contributor

/retest

2 similar comments
@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

4 similar comments
@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 6395bdd into pingcap:release-7.5 Jul 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants