Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: fix ddl exchange partition xxxx with validation to deal with with validation correctly #10867

Merged
merged 1 commit into from
Apr 1, 2024
Merged

ticdc: fix ddl exchange partition xxxx with validation to deal with with validation correctly #10867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cdc/model/sink.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,6 +1061,10 @@
d.Query = fmt.Sprintf("ALTER TABLE `%s`.`%s` EXCHANGE PARTITION `%s` WITH TABLE `%s`.`%s`",
tableInfo.TableName.Schema, tableInfo.TableName.Table, partName,
preTableInfo.TableName.Schema, preTableInfo.TableName.Table)

if strings.HasSuffix(upperQuery, "WITHOUT VALIDATION") {
d.Query += " WITHOUT VALIDATION"
}

Check warning on line 1067 in cdc/model/sink.go

View check run for this annotation

Codecov / codecov/patch

cdc/model/sink.go#L1066-L1067 

Added lines #L1066 - L1067 were not covered by tests
default:
d.Query = job.Query
}
Expand Down
Loading