Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: fix ddl exchange partition xxxx with validation to deal with with validation correctly #10867

Merged

Conversation

hongyunyan
Copy link
Collaborator

@hongyunyan hongyunyan commented Apr 1, 2024

What problem does this PR solve?

Issue Number: close #10859

What is changed and how it works?

Determine whether it is necessary to add without validation in the exchange partition.

Check List

Tests

  • Manual test
    test the case mentioned in issue, and check the result in downstream db.
    image

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Make `exchange partition` to deal with clause `with validation` correctly

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 1, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-01 07:45:17.098729669 +0000 UTC m=+257178.626270212: ☑️ agreed by asddongmen.
  • 2024-04-01 07:48:22.977920588 +0000 UTC m=+257364.505461129: ☑️ agreed by 3AceShowHand.

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Merging #10867 (20a1552) into master (db60e9e) will increase coverage by 0.2540%.
Report is 1 commits behind head on master.
The diff coverage is 25.0000%.

Additional details and impacted files
Components Coverage Δ
cdc 62.3351% <25.0000%> (+0.4576%) ⬆️
dm 51.2475% <ø> (-0.0021%) ⬇️
engine 63.4232% <ø> (+0.0282%) ⬆️
Flag Coverage Δ
unit 57.8099% <25.0000%> (+0.2540%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10867        +/-   ##
================================================
+ Coverage   57.5558%   57.8099%   +0.2540%     
================================================
  Files           853        853                
  Lines        126974     127767       +793     
================================================
+ Hits          73081      73862       +781     
+ Misses        48454      48451         -3     
- Partials       5439       5454        +15     

@hongyunyan
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 4024a44 into pingcap:master Apr 1, 2024
28 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10868.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 2, 2024
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 3, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10902.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 11, 2024
@hongyunyan hongyunyan added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Apr 29, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11008.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc: EXCHANGE PARTITION dropped the WITHOUT VALIDATION clause
4 participants