processor: fix task status is always flushed because of incorrect mod revision cache (#1017) #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
ti-srebot
added
type/bugfix
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1019 +/- ##
================================================
Coverage ? 31.5641%
================================================
Files ? 101
Lines ? 11041
Branches ? 0
================================================
Hits ? 3485
Misses ? 7160
Partials ? 396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1017 to release-4.0
What problem does this PR solve?
After investigating the https://github.com/pingcap/ticdc/issues/993, found key
/tidb/cdc/task/status/<capture-id>/<changefeed-id>is always updated when processor callsflushTaskStatusAndPositionThis bug happens since v4.0.5
What is changed and how it works?
The fix is straightforward, check
newModRevisionreturned byAtomicPutTaskStatus,newModRevision=0means status is not updated, we don't update the mod revision cache.Check List
Tests
Related changes
Release note