processor: fix task status is always flushed because of incorrect mod…

… revision cache (#1017) (#1019) Signed-off-by: ti-srebot <[email protected]>
pingcap · Oct 22, 2020 · 473e9cb · 473e9cb
1 parent 09c1fd6
commit 473e9cb
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/cdc/processor.go b/cdc/processor.go
@@ -551,8 +551,11 @@ func (p *processor) flushTaskStatusAndPosition(ctx context.Context) error {
 	for _, tableID := range tablesToRemove {
 		p.removeTable(tableID)
 	}
-	p.statusModRevision = newModRevision
-	p.status = newTaskStatus
+	// newModRevision == 0 means status is not updated
+	if newModRevision > 0 {
+		p.statusModRevision = newModRevision
+		p.status = newTaskStatus
+	}
 	syncTableNumGauge.
 		WithLabelValues(p.changefeedID, p.captureInfo.AdvertiseAddr).
 		Set(float64(len(p.status.Tables)))