Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Disable some tests of inactivated features on 7.5 #9466

Merged
merged 3 commits into from
Sep 25, 2024
Merged

tests: Disable some tests of inactivated features on 7.5 #9466

merged 3 commits into from
Sep 25, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Sep 24, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9405

Problem Summary:

  1. SimpleWriteReadAfterRestoreFromCheckPoint is an FAP soft error that pending investigation.
  2. KVStoreSingleSnap4 is a Parallel Prehandle bug that need to be picked into cse. The issue is ParallelPrehandle: executeParallelTransform could return Aborted if there is ErrUpdateSchema (release-7.5) #9405

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
a
0a25a88 
Signed-off-by: Calvin Neo <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 24, 2024
@CalvinNeo CalvinNeo changed the title Disable some tests of unactivated features on 7.5 Disable some tests of inactivated features on 7.5 Sep 24, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 24, 2024
JaySon-Huang
JaySon-Huang reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More elegant way to comment out a large block of codes

dbms/src/Storages/DeltaMerge/tests/gtest_dm_delta_merge_store_fast_add_peer.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/KVStore/tests/gtest_raftstore_v2.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/KVStore/tests/gtest_raftstore_v2.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/KVStore/tests/gtest_raftstore_v2.cpp Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 25, 2024
@JaySon-Huang JaySon-Huang changed the title Disable some tests of inactivated features on 7.5 tests: Disable some tests of inactivated features on 7.5 Sep 25, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 25, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 25, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 25, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-24 03:46:15.164032645 +0000 UTC m=+1537644.904456582: ☑️ agreed by Lloyd-Pottiger.
  • 2024-09-25 11:52:14.086960386 +0000 UTC m=+1653203.827384343: ☑️ agreed by JaySon-Huang.

@Lloyd-Pottiger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 9420fa4 into pingcap:release-7.5 Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CalvinNeo @Lloyd-Pottiger @JaySon-Huang @purelind