Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParallelPrehandle: executeParallelTransform could return Aborted if there is ErrUpdateSchema (release-7.5) #9405

Closed
CalvinNeo opened this issue Sep 3, 2024 · 5 comments
Closed

ParallelPrehandle: executeParallelTransform could return Aborted if there is ErrUpdateSchema (release-7.5) #9405

CalvinNeo opened this issue Sep 3, 2024 · 5 comments
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. component/storage severity/moderate type/bug The issue is confirmed as a bug.

Comments

@CalvinNeo
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)
@CalvinNeo CalvinNeo added the type/bug The issue is confirmed as a bug. label Sep 3, 2024
@JaySon-Huang
Copy link
Contributor

@CalvinNeo Can you add more description about this issue?

@CalvinNeo
Copy link
Member Author

In master,

tiflash/dbms/src/Storages/KVStore/MultiRaft/PrehandleSnapshot.cpp

Line 206 in b30c1f5

res = ReadFromStreamResult{.error = abort_reason.value(), .extra_msg = "", .region = new_region};
will replicate reason when abort.

However, release-7.5 will not.

So if the result is errupdateschema and aborted, and aborted is handled the first, then prehandle will not retry

@CalvinNeo CalvinNeo added affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/moderate labels Sep 4, 2024
@CalvinNeo
Copy link
Member Author

In 7.5, parallel prehandle is not enabled, so the severity is moderate.

@CalvinNeo
Copy link
Member Author

See #8246

@CalvinNeo CalvinNeo mentioned this issue Sep 24, 2024
Merged
12 tasks
@CalvinNeo CalvinNeo changed the title ParallelPrehandle: executeParallelTransform could return Aborted if there is ErrUpdateSchema ParallelPrehandle: executeParallelTransform could return Aborted if there is ErrUpdateSchema (release-7.5) Sep 24, 2024
ti-chi-bot bot pushed a commit that referenced this issue Sep 25, 2024
@CalvinNeo @purelind @JaySon-Huang
tests: Disable some tests of inactivated features on 7.5 (#9466)
9420fa4 
close #9405

Signed-off-by: Calvin Neo <[email protected]>

Co-authored-by: Purelind <[email protected]>
Co-authored-by: JaySon <[email protected]>
@CalvinNeo
Copy link
Member Author

Merged in https://github.com/tidbcloud/tiflash-cse/pull/301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. component/storage severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JaySon-Huang @CalvinNeo