Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disagg: Add nullptr check on S3LockLocalManager #9387

Merged
merged 8 commits into from
Sep 2, 2024
Merged

Disagg: Add nullptr check on S3LockLocalManager #9387

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7d7c359
a
CalvinNeo Aug 30, 2024
0e6b677
Update dbms/src/Storages/Page/V3/Universal/S3LockLocalManager.cpp
CalvinNeo Aug 30, 2024
fa6f368
Merge branch 'master' into fix-s3-lock
CalvinNeo Sep 2, 2024
879dfa0
a
CalvinNeo Sep 2, 2024
7cb4ed9
Merge branch 'fix-s3-lock' of github.com:CalvinNeo/tics into fix-s3-lock
CalvinNeo Sep 2, 2024
736327f
a
CalvinNeo Sep 2, 2024
6fe719a
Merge branch 'master' into fix-s3-lock
CalvinNeo Sep 2, 2024
ca0c0c9
Merge branch 'master' into fix-s3-lock
ti-chi-bot[bot] Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dbms/src/Storages/Page/V3/Universal/S3LockLocalManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,10 @@ String S3LockLocalManager::createS3Lock(
}
else
{
if unlikely (s3lock_client == nullptr)
{
throw Exception(ErrorCodes::LOGICAL_ERROR, "S3 Lock Client is not initialized");
}
CalvinNeo marked this conversation as resolved.
Show resolved Hide resolved
// Try to create a lock file for the data file created by another store.
// e.g. Ingest some pages from CheckpointDataFile or DTFile when doing FAP,
// send rpc to S3LockService
Expand Down