Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disagg: Add nullptr check on S3LockLocalManager #9387

Merged
merged 8 commits into from
Sep 2, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
a
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
CalvinNeo committed Sep 2, 2024
commit 879dfa0567cadf81bd21f1b821ae9dad2a46f5e9
7 changes: 3 additions & 4 deletions dbms/src/Storages/Page/V3/Universal/S3LockLocalManager.cpp
Original file line number Diff line number Diff line change
@@ -96,6 +96,8 @@ std::optional<CheckpointProto::ManifestFilePrefix> S3LockLocalManager::initStore
}

s3lock_client = std::move(s3lock_client_);
RUNTIME_CHECK(s3lock_client != nullptr);

store_id = actual_store_id;

LOG_INFO(
@@ -223,10 +225,7 @@ String S3LockLocalManager::createS3Lock(
}
else
{
if unlikely (s3lock_client == nullptr)
{
throw Exception(ErrorCodes::LOGICAL_ERROR, "S3 Lock Client is not initialized");
}
RUNTIME_CHECK_MSG(s3lock_client, "S3 Lock Client is not initialized");
// Try to create a lock file for the data file created by another store.
// e.g. Ingest some pages from CheckpointDataFile or DTFile when doing FAP,
// send rpc to S3LockService