Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KVStore: Refine parallel prehandle snapshot (part-2) #9193

Merged
merged 8 commits into from
Aug 26, 2024
Merged

KVStore: Refine parallel prehandle snapshot (part-2) #9193

merged 8 commits into from
Aug 26, 2024

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Jul 5, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #8081

Problem Summary:
This is a PR following #9192

What is changed and how it works?

Simplify region_id, split_id logging when pre-handling snapshots
  • Replace Poco::Logger by DB::Logger in MonoSSTReader
  • MultiSSTReader will share the same LoggerPtr with its generated MonoSSTReader with the same suffix
  • In SSTFilesToBlockInputStream we create the DB::Logger with region_id and split_id as the suffix

So we don't need to keep region_id and split_id in each "SSTReader". And the param passing is simplified.

This PR is a preceding PR for #9198

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 5, 2024
@JaySon-Huang JaySon-Huang marked this pull request as draft July 5, 2024 09:36
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/needs-linked-issue labels Jul 5, 2024
@JaySon-Huang JaySon-Huang force-pushed the refine_wait_check_log branch 2 times, most recently from e4905fc to ae3e490 Compare July 8, 2024 09:07
@JaySon-Huang JaySon-Huang force-pushed the refine_wait_check_log branch 3 times, most recently from 51f08cf to 6794299 Compare July 8, 2024 11:37
@JaySon-Huang JaySon-Huang force-pushed the refine_wait_check_log branch 2 times, most recently from dc52cf9 to f83d2cb Compare July 8, 2024 11:53
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 8, 2024
@JaySon-Huang JaySon-Huang marked this pull request as ready for review July 8, 2024 12:02
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2024
Lloyd-Pottiger
Lloyd-Pottiger approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 9, 2024
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
@JaySon-Huang JaySon-Huang removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
@JaySon-Huang
Copy link
Contributor Author

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 9, 2024
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2024
CalvinNeo
CalvinNeo approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 26, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 02:17:05.584188026 +0000 UTC m=+323922.819422131: ☑️ agreed by Lloyd-Pottiger.
  • 2024-08-26 02:29:09.317289323 +0000 UTC m=+750944.451739443: ☑️ agreed by CalvinNeo.

@ti-chi-bot ti-chi-bot bot merged commit f0a4087 into pingcap:master Aug 26, 2024
5 checks passed
@JaySon-Huang JaySon-Huang deleted the refine_wait_check_log branch August 26, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaySon-Huang @CalvinNeo @Lloyd-Pottiger