-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KVStore: Refine parallel prehandle snapshot (part-1) #9192
Conversation
1f9bfde
to
c3a1f7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
Co-authored-by: Lloyd-Pottiger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #8081
Problem Summary:
I'd like to introduce a new layer
SnapshotSSTReader
and movegetApproxBytes
/findSplitKeys
into that layer. This could make the logic in parallel prehandle snapshots more clear.This PR is a preceding PR that refactors the code to simplify the following logical change.
New
SnapshotSSTReader
interface in later PR:What is changed and how it works?
extra_id
bysplit_id
executeParallelTransform
andexecuteTransform
to bestd::tuple<ReadFromStreamResult, PrehandleResult>
executeParallelTransform
to simplify the code indent layerCheck List
Tests
Side effects
Documentation
Release note