Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Use prefix tiflash_ for thread-wise memory alloc info #9114

Merged
merged 2 commits into from
Jun 3, 2024
Merged

*: Use prefix tiflash_ for thread-wise memory alloc info #9114

merged 2 commits into from
Jun 3, 2024

Conversation

CalvinNeo
Copy link
Member

What problem does this PR solve?

Issue Number: close #8835

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

CalvinNeo added 2 commits June 3, 2024 17:01
@CalvinNeo
change name
4ec90c0 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
change name
623460a 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2024
@CalvinNeo CalvinNeo changed the title change name *: Use prefix tiflash_ for thread-wise memory alloc info Jun 3, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 3, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 3, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-03 09:05:50.30533021 +0000 UTC m=+3285704.062465780: ☑️ agreed by Lloyd-Pottiger.
  • 2024-06-03 09:08:37.085315101 +0000 UTC m=+3285870.842450670: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit 9929b19 into pingcap:master Jun 3, 2024
5 checks passed
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
@CalvinNeo
*: Use prefix tiflash_ for thread-wise memory alloc info (pingcap#9114)…
29cf2b0 
… (pingcap#207)

Signed-off-by: CalvinNeo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JinheLin JinheLin JinheLin approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support thread-wise memory alloc/dealloc monitor
3 participants
@CalvinNeo @JinheLin @Lloyd-Pottiger