Skip to content

Commit

Permalink
*: Use prefix tiflash_ for thread-wise memory alloc info (#9114)
Browse files Browse the repository at this point in the history
close #8835

Signed-off-by: CalvinNeo <[email protected]>
  • Loading branch information
CalvinNeo authored Jun 3, 2024
1 parent 640f856 commit 9929b19
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion dbms/src/Common/TiFlashMetrics.h
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,7 @@ class TiFlashMetrics
static constexpr auto current_metrics_prefix = "tiflash_system_current_metric_";
static constexpr auto async_metrics_prefix = "tiflash_system_asynchronous_metric_";
static constexpr auto raft_proxy_thread_memory_usage = "tiflash_raft_proxy_thread_memory_usage";
static constexpr auto storages_thread_memory_usage = "storages_thread_memory_usage";
static constexpr auto storages_thread_memory_usage = "tiflash_storages_thread_memory_usage";

std::shared_ptr<prometheus::Registry> registry = std::make_shared<prometheus::Registry>();
// Here we add a ProcessCollector to collect cpu/rss/vsize/start_time information.
Expand Down
4 changes: 2 additions & 2 deletions metrics/grafana/tiflash_summary.json
Original file line number Diff line number Diff line change
Expand Up @@ -9053,7 +9053,7 @@
"targets": [
{
"exemplar": true,
"expr": "storages_thread_memory_usage{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\", type=~\"alloc_.*\"}",
"expr": "tiflash_storages_thread_memory_usage{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\", type=~\"alloc_.*\"}",
"format": "time_series",
"interval": "",
"intervalFactor": 2,
Expand All @@ -9062,7 +9062,7 @@
},
{
"exemplar": true,
"expr": "-storages_thread_memory_usage{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\", type=~\"dealloc_.*\"}",
"expr": "-tiflash_storages_thread_memory_usage{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\", type=~\"dealloc_.*\"}",
"format": "time_series",
"hide": false,
"interval": "",
Expand Down

0 comments on commit 9929b19

Please sign in to comment.