Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug: Add find key debug invoker #8853
Debug: Add find key debug invoker #8853
Changes from 44 commits
d0820f1
5de4f38
5c69e1c
49103c7
0346039
95d170f
7b27fe4
c943a82
8abdf59
68890ba
f2c6a5a
062fcf8
583fff9
2c7cd9a
ecfae28
fe16413
ad99e25
03680fe
832fbd6
2e75eeb
acc4137
f31705b
0f5c986
46a9bc1
a1c93d2
cf12c0b
24ee148
1cbcbf8
892fd5e
c36aa29
05323d5
f43325a
39cf3cb
535f125
1b18b88
404ea1b
9e7720a
6adbd98
c22d135
a192707
532794f
181f588
f7ba62d
fb04618
45de44d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to map the
table_name
in tidb to get its name in TiFlash (which ist_${table_id}
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems
tmt.getStorages().getByName(mapped_database_name, table_name, false)
here takes the un-mapped name, which is nott_$tid
, but its user name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to syncTableSchema here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure we have the table info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to make sure have the table info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some comments about this condition please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
(arg_size % 2) != 0
maybe a more readable way and their execution efficiency is the sameThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add a comment about the behavior at the beginning of this function.
When I see the
end_handle
is optional, I thought it would print all the following rows afterstart_handle
. But here the logic is when theend_handle
is ignored, it will only print one row.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed