Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug: Add find key debug invoker #8853

Merged
merged 45 commits into from
Mar 26, 2024
Merged

Debug: Add find key debug invoker #8853

merged 45 commits into from
Mar 26, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Mar 20, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #8864

Problem Summary:

In order to investigate #8845

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
init
d0820f1 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2024
@CalvinNeo
some debug
5de4f38 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2024
@CalvinNeo CalvinNeo changed the title init Debug: Add find key debug invoker Mar 20, 2024
@CalvinNeo
ICE
5c69e1c 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Mar 21, 2024 •
edited
Loading

image
image

@CalvinNeo
fmt
49103c7 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
remove genKey
0346039 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
1
95d170f 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fmt
7b27fe4 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fmt2
c943a82 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fmt
8abdf59 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fix
68890ba 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
f
f2c6a5a 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
z
062fcf8 
Signed-off-by: CalvinNeo <[email protected]>
Lloyd-Pottiger
Lloyd-Pottiger reviewed Mar 22, 2024
View reviewed changes
dbms/src/Storages/KVStore/Region.h Outdated Show resolved Hide resolved
dbms/src/Debug/dbgKVStore/dbgFuncRegion.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/MockTiDB.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/MockTiDB.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/dbgKVStore/dbgFuncInvestigator.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/dbgKVStore/dbgFuncInvestigator.cpp Show resolved Hide resolved
dbms/src/Debug/dbgKVStore/dbgFuncInvestigator.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/dbgKVStore/dbgFuncInvestigator.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/dbgKVStore/dbgFuncInvestigator.cpp Outdated Show resolved Hide resolved
dbms/src/Debug/dbgKVStore/dbgFuncInvestigator.cpp Show resolved Hide resolved
Lloyd-Pottiger
Lloyd-Pottiger reviewed Mar 22, 2024
View reviewed changes
dbms/src/Debug/DBGInvoker.cpp Outdated
Comment on lines 112 to 113
regSchemalessFunc("find_key_kvstore", dbgFuncFindKey);
regSchemafulFunc("find_key_dt", dbgFuncFindKeyDt);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comments here to explain how to use this

@CalvinNeo
f
583fff9 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fff
2c7cd9a 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fff
ecfae28 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo CalvinNeo requested a review from JaySon-Huang March 25, 2024 14:01
@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@CalvinNeo
fix release
f7ba62d 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
JaySon-Huang
JaySon-Huang reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 26, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-22 07:02:41.110732094 +0000 UTC m=+1619388.132978483: ☑️ agreed by Lloyd-Pottiger.
  • 2024-03-26 05:18:10.115538435 +0000 UTC m=+1958717.137784819: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit ce8ae39 into pingcap:master Mar 26, 2024
6 checks passed
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Apr 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9006.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 30, 2024
@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#8853
ef63c8d 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 30, 2024
Closed
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 30, 2024
@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#8853
e795a89 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9008.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 30, 2024
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9012.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 30, 2024
@CalvinNeo @ti-chi-bot
This is an automated cherry-pick of pingcap#8853
c1a9215 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 30, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JinheLin JinheLin JinheLin approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CalvinNeo @JaySon-Huang @ti-chi-bot @JinheLin @Lloyd-Pottiger