Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storages: Update the length of Block queue and the number of read threads (#8702) #8706

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8702

What problem does this PR solve?

Issue Number: close #8703

What is changed and how it works?

  • The length of Block queue:

    • For on-premise deployment, adjusting the length of the Block queue to 1.5 times of the current default value is expected to reduce the time required for simple queries by 3-6%.
    • For disaggregated deployment, adjusting the length of the Block queue to 1.5 times of the current default value is expected to reduce the time required for simple queries by 2-20%. The specific performance improvement depends on data caching. The less cached data, the more significant the improvement.
  • The number of read threads:

    • For disaggregated deployment, if most of the data cannot hit the local disk cache, the network will become a bottleneck, and increasing the number of threads can significantly improve performance. If more than half of the data is expected to hit the local cache, adjusting the number of threads to 2 times of the current default value is enough.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jan 18, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 19, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-19 03:07:42.305288388 +0000 UTC m=+498103.869586095: ☑️ agreed by JinheLin.
  • 2024-01-19 03:31:27.542331665 +0000 UTC m=+499529.106629355: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JinheLin
Copy link
Contributor

[2024-01-19T03:53:23.771Z] /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/tests/gtest_read_index_worker.cpp:390: Failure
[2024-01-19T03:53:23.771Z] Expected equality of these values:
[2024-01-19T03:53:23.771Z]   resps[2].first.read_index()
[2024-01-19T03:53:23.771Z]     Which is: 0
[2024-01-19T03:53:23.771Z]   669
[2024-01-19T03:53:23.771Z] libc++abi: terminating
[2024-01-19T03:53:23.771Z] Received signal Aborted
[2024-01-19T03:53:23.771Z] 
[2024-01-19T03:53:23.771Z]        0xff65c6e	StackTrace::StackTrace() [gtests_dbms+267803758]
[2024-01-19T03:53:23.771Z]        0x7527034	fault_signal_handler(int) [gtests_dbms+122843188]
[2024-01-19T03:53:23.771Z]   0x7f535ac69400	<unknown symbol> [libc.so.6+222208]
[2024-01-19T03:53:23.771Z]   0x7f535ac69387	raise [libc.so.6+222087]
[2024-01-19T03:53:23.771Z]   0x7f535ac6aa78	abort [libc.so.6+227960]
[2024-01-19T03:53:23.771Z]   0x7f535bc87866	abort_message [libc++abi.so.1+239718]
[2024-01-19T03:53:23.771Z]   0x7f535bc68efa	demangling_terminate_handler() [libc++abi.so.1+114426]
[2024-01-19T03:53:23.771Z]   0x7f535bc86a13	std::__terminate(void (*)()) [libc++abi.so.1+236051]
[2024-01-19T03:53:23.771Z]   0x7f535bc869a2	std::terminate() [libc++abi.so.1+235938]
[2024-01-19T03:53:23.771Z]   0x7f535bd028ce	std::__1::thread::~thread() [libc++.so.1+461006]
[2024-01-19T03:53:23.771Z]        0x7395a37	DB::tests::ReadIndexTest::testNormal() [gtests_dbms+121199159]
[2024-01-19T03:53:23.771Z]        0x739b191	DB::tests::ReadIndexTest_workers_Test::TestBody() [gtests_dbms+121221521]
[2024-01-19T03:53:23.771Z]        0xd6142db	void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) [gtests_dbms+224477915]
[2024-01-19T03:53:23.771Z]        0xd60173a	void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) [gtests_dbms+224401210]
[2024-01-19T03:53:23.771Z]        0xd5e6c8c	testing::Test::Run() [gtests_dbms+224291980]
[2024-01-19T03:53:23.771Z]        0xd5e77aa	testing::TestInfo::Run() [gtests_dbms+224294826]
[2024-01-19T03:53:23.771Z]        0xd5e7d63	testing::TestCase::Run() [gtests_dbms+224296291]
[2024-01-19T03:53:23.771Z]        0xd5f1f13	testing::internal::UnitTestImpl::RunAllTests() [gtests_dbms+224337683]
[2024-01-19T03:53:23.771Z]        0xd617b0b	bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) [gtests_dbms+224492299]
[2024-01-19T03:53:23.771Z]        0xd60377a	bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) [gtests_dbms+224409466]
[2024-01-19T03:53:23.772Z]        0xd5f1c26	testing::UnitTest::Run() [gtests_dbms+224336934]
[2024-01-19T03:53:23.772Z]        0x752b501	RUN_ALL_TESTS() [gtests_dbms+122860801]
[2024-01-19T03:53:23.772Z]        0x7527932	main [gtests_dbms+122845490]
[2024-01-19T03:53:23.772Z]   0x7f535ac55555	__libc_start_main [libc.so.6+140629]
[2024-01-19T03:53:23.772Z]        0x43311a9	<unknown symbol> [gtests_dbms+70455721]
[2024-01-19T03:53:23.772Z] [1300/2113] ReadIndexTest.workers returned/aborted with exit code -6 (2237 ms)

@JinheLin
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit a4e37a3 into pingcap:release-7.1 Jan 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants