Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storages: Update the length of Block queue and the number of read threads #8702

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Jan 18, 2024

What problem does this PR solve?

Issue Number: close #8703

What is changed and how it works?

  • The length of Block queue:

    • For on-premise deployment, adjusting the length of the Block queue to 1.5 times of the current default value is expected to reduce the time required for simple queries by 3-6%.
    • For disaggregated deployment, adjusting the length of the Block queue to 1.5 times of the current default value is expected to reduce the time required for simple queries by 2-20%. The specific performance improvement depends on data caching. The less cached data, the more significant the improvement.
  • The number of read threads:

    • For disaggregated deployment, if most of the data cannot hit the local disk cache, the network will become a bottleneck, and increasing the number of threads can significantly improve performance. If more than half of the data is expected to hit the local cache, adjusting the number of threads to 2 times of the current default value is enough.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2024
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it should be picked back to release-7.5 at least. What about the release-6.5 and release-6.1?

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 18, 2024
@JinheLin
Copy link
Contributor Author

LGTM

I think it should be picked back to release-7.5 at least. What about the release-6.5 and release-6.1?

Yes. I will update the issue later.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jan 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-18 08:11:58.827087768 +0000 UTC m=+429960.391385473: ☑️ agreed by JaySon-Huang.
  • 2024-01-18 10:09:20.676115902 +0000 UTC m=+437002.240413628: ☑️ agreed by Lloyd-Pottiger.

Copy link
Contributor

ti-chi-bot bot commented Jan 18, 2024

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 1614f4a into pingcap:master Jan 18, 2024
6 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 18, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8706.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8707.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 18, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8708.

ti-chi-bot bot pushed a commit that referenced this pull request Jan 19, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jan 19, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jan 19, 2024
JinheLin added a commit that referenced this pull request Jan 25, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the length of Block queue and the number of read threads
4 participants