Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minmax: fix copy index data in a wrong way (#8302) #8303

Merged
merged 1 commit into from
Nov 3, 2023
Merged

minmax: fix copy index data in a wrong way (#8302) #8303

merged 1 commit into from
Nov 3, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8302

What problem does this PR solve?

Issue Number: close #8301

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Nov 3, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 3, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 3, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2023
@Lloyd-Pottiger
f
5a14f06 
Signed-off-by: Lloyd-Pottiger <[email protected]>
JaySon-Huang
JaySon-Huang reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts need to be resolved

@Lloyd-Pottiger Lloyd-Pottiger force-pushed the cherry-pick-8302-to-release-6.1 branch from 3054999 to 5a14f06 Compare November 3, 2023 02:37
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 3, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 3, 2023
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 3, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 3, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-03 02:42:11.548511074 +0000 UTC m=+3180129.135621212: ☑️ agreed by JaySon-Huang.
  • 2023-11-03 02:47:50.878273176 +0000 UTC m=+3180468.465383306: ☑️ agreed by Lloyd-Pottiger.

@JaySon-Huang
Copy link
Contributor

The unit test to the old TLS branches is broken by PingCAP-QE/ci#2515 enabling the bench_dbms which is actually get broken.
I'm trying to fix it

@JaySon-Huang
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 3a7bd02 into pingcap:release-6.1 Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@Lloyd-Pottiger Lloyd-Pottiger

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @JaySon-Huang @Lloyd-Pottiger