Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add building bench_dbms to tiflash ci pipeline #2515

Merged
merged 1 commit into from
Oct 17, 2023
Merged

add building bench_dbms to tiflash ci pipeline #2515

merged 1 commit into from
Oct 17, 2023

Conversation

guo-shaoge
Copy link
Contributor

No description provided.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the PR title and the diff, it seems the change is adding bench_dbms target to the BUILD_TESTS option in the tiflash-build-common.groovy file. This is probably to include bench_dbms in the CI pipeline for TiFlash.

Potential problems:

  • It's difficult to identify any potential problems without information on what bench_dbms is and how it will affect the CI pipeline.

Fixing suggestions:

  • If bench_dbms is a new feature that hasn't been tested before, it might be a good idea to add a new job to the CI pipeline that specifically tests bench_dbms before merging this PR.
  • If bench_dbms has already been tested and integrated into the TiFlash codebase, then this PR seems to be okay as is.

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and wuhuizuo October 16, 2023 03:38
@guo-shaoge
Copy link
Contributor Author

/hold

@guo-shaoge
Copy link
Contributor Author

wait for pingcap/tiflash#8194

@ti-chi-bot ti-chi-bot bot added the size/XS label Oct 16, 2023
@purelind
Copy link
Collaborator

replay test passed https://ci.pingcap.net/blue/organizations/jenkins/tiflash-build-common/detail/tiflash-build-common/30799/pipeline/166

purelind
purelind approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-16 06:04:05.915475637 +0000 UTC m=+1637043.502585782: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 16, 2023
@purelind
Copy link
Collaborator

/unhold

@ti-chi-bot ti-chi-bot bot merged commit bd822e7 into PingCAP-QE:main Oct 17, 2023
This was referenced Nov 3, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 3, 2023
@JaySon-Huang
Only build bench for the master branch (#2584)
177d94f 
The previous PR enables the bench_dbms
#2515 to ensure the new code
changes do not break building the bench binary.
But in the old branches, the bench binary have been broken for a long
days and it brings trouble for cherry-pick to LTS branches and hotfix
branches.

This PR only build the bench_dbms on the master branch. Ignore it for
the LTS branches and hotfix branches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purelind purelind purelind approved these changes

@jayl1e jayl1e Awaiting requested review from jayl1e

@wuhuizuo wuhuizuo Awaiting requested review from wuhuizuo

Assignees

@purelind purelind

Labels
approved lgtm size/XS
Projects
EE - CI/CD system
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guo-shaoge @purelind