fix data race in join auto spill (#8145)

[ti-chi-bot]

This is an automated cherry-pick of #8145

What problem does this PR solve?

Issue Number: close #8144

Problem Summary:

What is changed and how it works?

Fix data race in join auto spill.
The root cause is join spill will call spilled_partition_indexes.push_back(i); concurrently in auto spill mode.
This pr fix it by

• Rename spilled_partition_indexes to remaining_partition_indexes_to_restore, and only use this during restore stage
• Init remaining_partition_indexes_to_restore in workAfterBuildFinish, which is thread safe.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[yibin87]

LGTM

[windtalker]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [windtalker,yibin87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-09-27 01:18:59.089010326 +0000 UTC m=+410528.807352543: ☑️ agreed by yibin87.
• 2023-09-27 01:26:44.416443862 +0000 UTC m=+410994.134786082: ☑️ agreed by windtalker.

[windtalker]

/run-all-tests

[windtalker]

/run-unit-tests