-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix data race in join auto spill #8145
fix data race in join auto spill #8145
Conversation
Signed-off-by: xufei <[email protected]>
a73f1df
to
3eeaf7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
Co-authored-by: SeaRise <[email protected]>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SeaRise, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #8144
Problem Summary:
What is changed and how it works?
Fix data race in join auto spill.
The root cause is join spill will call
spilled_partition_indexes.push_back(i);
concurrently in auto spill mode.This pr fix it by
spilled_partition_indexes
toremaining_partition_indexes_to_restore
, and only use this during restore stageremaining_partition_indexes_to_restore
inworkAfterBuildFinish
, which is thread safe.Check List
Tests
Side effects
Documentation
Release note