Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert gc speed related optimization #7923

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Revert gc speed related optimization #7923

merged 4 commits into from
Aug 10, 2023

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Aug 10, 2023 •
edited by flowbehappy
Loading

What problem does this PR solve?

Issue Number: close #7925

Problem Summary: as stated in #7922

What is changed and how it works?

Revert gc related optimization in #7668 and #7779

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 10, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 10, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 10, 2023

/run-unit-test

@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 10, 2023

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 10, 2023

/run-integration-test

@flowbehappy
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2023
@flowbehappy
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 10, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 10, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flowbehappy, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,flowbehappy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 10, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-10 06:59:28.736351434 +0000 UTC m=+182333.285367421: ☑️ agreed by flowbehappy.
  • 2023-08-10 07:01:05.432501913 +0000 UTC m=+182429.981517899: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit 7189768 into pingcap:release-7.3 Aug 10, 2023
@lidezhu lidezhu deleted the revert-gc-optimize-7.3 branch August 10, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lidezhu @flowbehappy @JaySon-Huang @ti-chi-bot