improve ps gc speed by dumping snapshot from memory directly #7668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
lidezhu
changed the title
|
/rebuild |
|
/run-all-tests |
|
/rebuild |
|
/run-integration-test |
lidezhu
force-pushed
the
multi-version-ref-count
branch
from
cc293ce to
cc2038d
Compare
|
/run-unit-test |
|
/run-all-tests |
|
/run-all-tests |
|
/run-integration-test |
1 similar comment
|
/run-integration-test |
|
/run-all-tests |
|
/run-integration-test |
1 similar comment
|
/run-integration-test |
Co-authored-by: JaySon <[email protected]>
flowbehappy
reviewed
Jun 21, 2023
flowbehappy
approved these changes
Jun 26, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/run-all-tests |
Co-authored-by: JaySon <[email protected]>
lidezhu
force-pushed
the
multi-version-ref-count
branch
from
8a47ca1 to
0232dea
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flowbehappy, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/merge |
|
/run-all-tests |
|
/run-unit-test |
This was referenced Jul 13, 2023
lidezhu
added a commit
to lidezhu/tics
that referenced
this pull request
Aug 10, 2023
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #6827
Problem Summary: Previously, when dumping snapshot for
PageDirectory, we load all target wal files and create a temp PageDirectory for dumping. And after dumping the snapshot, we can reclaim all the target wal files.But under heavy write scenario, the dump snapshot speed is a little slow. This will make the number of wal files keep increasing and make the process of dumping snapshot cost more and more memory.
What is changed and how it works?
Change the type of
being_ref_countfromInt64toMultiVersionRefCount *;being_ref_countis nullptr, it means1;PageVersion -> RefCountinsideMultiVersionRefCount;getLatestRefCountandappendRefCount;decrLatestRefCountInSnap. And it will also reclaim older version of ref count;When dumping snapshot, ref count increasing caused by new ref page will just be appended to
MultiVersionRefCount, so it won't affect the ref count value that the snapshot can see.GC process can still change ref count value for a snapshot, but it doesn't matter because gc won't run concurrently with dumping snapshot.
Check List
Tests
Side effects
Documentation
Release note