Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease write latency in PageStorage #7783

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Jul 10, 2023

What problem does this PR solve?

Issue Number: close #7735 close #7736

Problem Summary: cherry pick of #7154 and #7616

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 10, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 10, 2023

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 10, 2023

/run-unit-test

@purelind
Copy link
Collaborator

/run-unit-test

Please specify tidb=release-6.5 to trigger integration testing.

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 10, 2023

/run-integration-test tidb=release-6.5

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 11, 2023

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 11, 2023

/run-unit-test

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 11, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 11, 2023

/run-integration-test tidb=release-6.5

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 11, 2023

/run-unit-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-11 02:37:26.45745449 +0000 UTC m=+385938.227793202: ☑️ agreed by JaySon-Huang.
  • 2023-07-11 02:49:22.165358566 +0000 UTC m=+386653.935697279: ☑️ agreed by Lloyd-Pottiger.

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 11, 2023

/run-unit-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

@lidezhu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 11, 2023

/run-integration-test tidb=release-6.5

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 11, 2023

@ti-chi-bot ti-chi-bot bot merged commit b34a12a into pingcap:release-6.5-20230710-v6.5.2 Jul 11, 2023
@lidezhu lidezhu deleted the cherry-pick-ps-optimization-to-6.5.2 branch July 11, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230710-v6.5.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants