Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease ps write latency #7154

Merged
merged 6 commits into from
Mar 24, 2023
Merged

Decrease ps write latency #7154

merged 6 commits into from
Mar 24, 2023

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Mar 24, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6827 close #7735

Problem Summary: We need to decrease ps write latency.

What is changed and how it works?

Make apply to PageDirectory a pipeline so that we can batch the incoming edit when doing IO.
Before optimization
aeb252db-79fe-494a-b46a-e8ad6e6b5235
After optimization
19c406a7-932f-4ca1-834b-28e5dceac01c
The 99-latency decrease from 40ms to 12ms.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2023
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2023
@lidezhu lidezhu changed the title [WIP] Improve ps write latency Decrease ps write latency Mar 24, 2023
@ti-chi-bot ti-chi-bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Mar 24, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 24, 2023

/run-all-tests

flowbehappy
flowbehappy reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CalvinNeo
CalvinNeo approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2023
@flowbehappy flowbehappy self-requested a review March 24, 2023 09:37
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2023
@flowbehappy
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0709a1a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 24, 2023

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2023
JaySon-Huang
JaySon-Huang approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 24, 2023

The code for handling exception is not ready.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 24, 2023

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 24, 2023

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 24, 2023

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 24, 2023

@flowbehappy @CalvinNeo @JaySon-Huang Add some new code for handling exception, PTAL again

@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 24, 2023

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 24, 2023

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0e12dcc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 24, 2023

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit ea748e8 into pingcap:master Mar 24, 2023
@lidezhu lidezhu deleted the improve-ps-write branch March 24, 2023 15:22
@lidezhu lidezhu added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jul 4, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 4, 2023

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7737.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 4, 2023
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 4, 2023
@lidezhu @ti-chi-bot
This is an automated cherry-pick of pingcap#7154
987228c 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 4, 2023
@ti-chi-bot
Decrease ps write latency (#7154) (#7737)
5b97981 
ref #6827, close #7735
lidezhu pushed a commit to lidezhu/tics that referenced this pull request Jul 10, 2023
@ti-chi-bot @lidezhu
Decrease ps write latency (pingcap#7154) (pingcap#7737)
ec3e774
@lidezhu lidezhu mentioned this pull request Jul 10, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the problem that ps write latency too high under high concurrency
5 participants
@lidezhu @ti-chi-bot @flowbehappy @JaySon-Huang @CalvinNeo