Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASH-1188] Make compact_log_min_period 0 as default (#719) #721

Merged
merged 1 commit into from
May 26, 2020

Conversation

sre-bot
Copy link
Collaborator

@sre-bot sre-bot commented May 26, 2020

cherry-pick #719 to release-4.0


  • Make compact_log_min_period 0 as default.

  • Discard ComputeHash and VerifyHash by default.

@sre-bot sre-bot added the CHERRY-PICK cherry pick label May 26, 2020
@solotzg solotzg added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2020
@sre-bot
Copy link
Collaborator Author

sre-bot commented May 26, 2020

/run-all-tests

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solotzg solotzg added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels May 26, 2020
@sre-bot
Copy link
Collaborator Author

sre-bot commented May 26, 2020

@sre-bot merge failed.

@sre-bot
Copy link
Collaborator Author

sre-bot commented May 26, 2020

/run-all-tests

1 similar comment
@solotzg
Copy link
Contributor

solotzg commented May 26, 2020

/run-all-tests

@sre-bot sre-bot merged commit 33eaf84 into pingcap:release-4.0 May 26, 2020
@solotzg solotzg deleted the release-4.0-4f6adbae3fb8 branch May 26, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants