Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASH-1188] Make compact_log_min_period 0 as default #719

Merged
merged 1 commit into from
May 26, 2020
Merged

[FLASH-1188] Make compact_log_min_period 0 as default #719

merged 1 commit into from
May 26, 2020

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented May 25, 2020

  • Make compact_log_min_period 0 as default.

  • Discard ComputeHash and VerifyHash by default.

@solotzg solotzg requested a review from flowbehappy May 25, 2020 13:56
@solotzg solotzg added needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 labels May 25, 2020
@solotzg
Copy link
Contributor Author

solotzg commented May 25, 2020

/rebuild

@solotzg
Copy link
Contributor Author

solotzg commented May 25, 2020

/run-all-tests

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanmato1984 zanmato1984 merged commit 4f6adba into pingcap:master May 26, 2020
@solotzg solotzg deleted the FLASH-1188 branch May 26, 2020 04:14
@JaySon-Huang
Copy link
Contributor

/run-cherry-picker

@sre-bot
Copy link
Collaborator

sre-bot commented May 26, 2020

cherry pick to release-3.1 in PR #720

@sre-bot
Copy link
Collaborator

sre-bot commented May 26, 2020

cherry pick to release-4.0 in PR #721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants