Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine join probe #7156

Merged
merged 17 commits into from
Apr 10, 2023
Merged

Refine join probe #7156

merged 17 commits into from
Apr 10, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Mar 24, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5900

Problem Summary:

What is changed and how it works?

  • move some codes from HashJoinProbeBlockInputStream to HashJoinProbeExec

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 24, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 24, 2023

/run-all-tests

@SeaRise SeaRise requested a review from windtalker March 24, 2023 08:57
@SeaRise SeaRise force-pushed the refine_join_probe branch from cda798d to 4619f6f Compare March 27, 2023 02:05
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2023
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 27, 2023

/run-all-tests

@SeaRise SeaRise requested a review from gengliqi March 29, 2023 06:10
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 5, 2023

/run-all-tests

yibin87
yibin87 approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run new added spill random failpoint tests by windtalker before merge, others LGTM.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 6, 2023
@SeaRise SeaRise force-pushed the refine_join_probe branch from 662639d to cf5deb8 Compare April 7, 2023 09:01
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 7, 2023

/run-all-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2023
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2023
windtalker
windtalker reviewed Apr 10, 2023
View reviewed changes
dbms/src/DataStreams/HashJoinProbeBlockInputStream.cpp Show resolved Hide resolved
dbms/src/DataStreams/HashJoinProbeExec.h Outdated
ProbeProcessInfo probe_process_info;
PartitionBlocks probe_partition_blocks;

std::optional<HashJoinProbeExecPtr> parent;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems HashJoinProbeExecPtr itself can be used as a optional class for ptr, why not wrap HashJoinProbeExecPtr with another optional type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean just use HashJoinProbeExecPtr here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, updated.

@SeaRise SeaRise requested a review from windtalker April 10, 2023 04:47
windtalker
windtalker approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 10, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 10, 2023

Please run new added spill random failpoint tests by windtalker before merge, others LGTM.

done

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 10, 2023

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c309323

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2023
@ti-chi-bot
Copy link
Member

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 0f82b2e into pingcap:master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@windtalker windtalker windtalker approved these changes

@gengliqi gengliqi Awaiting requested review from gengliqi

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the code of the TiFlash computing layer
4 participants
@SeaRise @ti-chi-bot @windtalker @yibin87