Refine join probe (#7156)

close #5900
pingcap · Apr 10, 2023 · 0f82b2e · 0f82b2e
1 parent e0c82c0
commit 0f82b2e
Show file tree

Hide file tree

Showing 7 changed files with 514 additions and 274 deletions.
diff --git a/dbms/src/Common/PtrHolder.h b/dbms/src/Common/PtrHolder.h
@@ -15,6 +15,7 @@
 #pragma once
 
 #include <mutex>
+#include <optional>
 
 namespace DB
 {
@@ -26,7 +27,6 @@ class PtrHolder
     {
         assert(obj_);
         std::lock_guard lock(mu);
-        assert(!obj);
         obj = std::move(obj_);
     }
 
@@ -39,13 +39,20 @@ class PtrHolder
         return res;
     }
 
-    auto operator->()
+    auto * operator->()
     {
         std::lock_guard lock(mu);
         assert(obj != nullptr);
         return obj.get();
     }
 
+    auto & operator*()
+    {
+        std::lock_guard lock(mu);
+        assert(obj != nullptr);
+        return *obj.get();
+    }
+
 private:
     std::mutex mu;
     Ptr obj;