fix the problem that offset in limit query for tiflash system tables doesn't take effect (#6745) #6761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6745
What problem does this PR solve?
Issue Number: close #6747
Problem Summary: When query tiflash system tables from tidb, tidb will send query like
select ... limit offset, 1024
. And the query only stops when the num of return rows is less thanlength
. However, theoffset
parameter is not repected by tiflash, and will always return the same result with anyoffset
value. So if the system table has more than 1024 rows, the query will hang forever.What is changed and how it works?
Port the implementation from https://github.com/ClickHouse/ClickHouse/blob/19.5/dbms/src/DataStreams/LimitBlockInputStream.cpp#L21
Check List
Tests
dt_segments
with more than 1024 rows;select count(*) from information_schema.tiflash_segments
and make sure it succeeds;Side effects
Documentation
Release note