Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the problem that offset in limit query for tiflash system tables doesn't take effect #6745

Merged
merged 6 commits into from
Feb 7, 2023

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Feb 6, 2023

What problem does this PR solve?

Issue Number: close #6747

Problem Summary: When query tiflash system tables from tidb, tidb will send query like select ... limit offset, 1024. And the query only stops when the num of return rows is less than length. However, the offset parameter is not repected by tiflash, and will always return the same result with any offset value. So if the system table has more than 1024 rows, the query will hang forever.

What is changed and how it works?

Port the implementation from https://github.com/ClickHouse/ClickHouse/blob/19.5/dbms/src/DataStreams/LimitBlockInputStream.cpp#L21

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. deploy a cluster and import data to make the tiflash system tables dt_segments with more than 1024 rows;
  2. run the query select count(*) from information_schema.tiflash_segments and make sure it succeeds;
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 6, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gengliqi
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2023
@lidezhu lidezhu force-pushed the fix-read-system-table branch from 2c6de3c to fa1a347 Compare February 6, 2023 09:53
@lidezhu lidezhu changed the title fix the problem that offset in limit query doesn't take effect fix the problem that offset in limit query for tiflash system tables doesn't take effect Feb 6, 2023
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 6, 2023
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2023
@JaySon-Huang
Copy link
Contributor

Does this bug also affect the v5.x versions or only the v6.x versions?

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2023
Copy link
Contributor

@gengliqi gengliqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 7, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.2: #6759.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 7, 2023
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 7, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #6760.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 7, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #6761.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #6762.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 7, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #6763.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 7, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.0: #6764.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 7, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 7, 2023

Does this bug also affect the v5.x versions or only the v6.x versions?

After verification, it just affect the master branch.

@lidezhu lidezhu removed needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Feb 7, 2023
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 7, 2023
@JaySon-Huang
Copy link
Contributor

Does this bug also affect the v5.x versions or only the v6.x versions?

After verification, it just affect the master branch.

OK, I think it is introduced by this PR: #6268

ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023
…doesn't take effect (pingcap#6745)

* respect offset in LimitBlockInputStream

* remove LimitTransformAction

* fix unit test

Signed-off-by: ywqzzy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offset in limit query for tiflash system tables doesn't take effect
6 participants