Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for fine-grained join & agg #6445

Merged
merged 9 commits into from
Dec 23, 2022
Merged

Add unit tests for fine-grained join & agg #6445

merged 9 commits into from
Dec 23, 2022

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Dec 8, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6157

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@yibin87 yibin87 requested review from SeaRise and ywqzzy December 8, 2022 03:13
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mengxin9014
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 8, 2022
@yibin87
Copy link
Contributor Author

yibin87 commented Dec 8, 2022

unhold until #6442 is fixed.

@yibin87
Copy link
Contributor Author

yibin87 commented Dec 8, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2022
@yibin87
Little refact
4d5a0f0 
Signed-off-by: yibin <[email protected]>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2022
@yibin87
Copy link
Contributor Author

yibin87 commented Dec 23, 2022

/run-all-tests

ywqzzy
ywqzzy reviewed Dec 23, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dbms/src/Flash/tests/gtest_compute_server.cpp
}
case tipb::ExecType::TypeExchangeSender:
if (current->exchange_sender().tp() == tipb::Hash)
current->set_fine_grained_shuffle_stream_count(8);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can modify the AggregationBinder::toMPPSubPlan to pass the fine_grained_shuffle_stream_count to ExchangeReceiverBinder and ExchangeSenderBinder.
Then the ExchangexxxBinder can use fine_grained_shuffle_stream_count to set the tipb::Executor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can modify the AggregationBinder::toMPPSubPlan to pass the fine_grained_shuffle_stream_count to ExchangeReceiverBinder and ExchangeSenderBinder. Then the ExchangexxxBinder can use fine_grained_shuffle_stream_count to set the tipb::Executor

I will refactor it when this pr merged.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 23, 2022
@yibin87
Copy link
Contributor Author

yibin87 commented Dec 23, 2022

/run-all-tests

@yibin87 yibin87 requested a review from mengxin9014 December 23, 2022 04:55
@yibin87
Copy link
Contributor Author

yibin87 commented Dec 23, 2022

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Dec 23, 2022

It looks like ComputeServerRunner.runFineGrainedShuffleJoinTest has had a crash.

[2022-12-23T04:54:59.670Z] /usr/local/bin/../include/c++/v1/vector:1580: _LIBCPP_ASSERT '__n < size()' failed. vector[] index out of bounds

@yibin87
Copy link
Contributor Author

yibin87 commented Dec 23, 2022

It looks like ComputeServerRunner.runFineGrainedShuffleJoinTest has had a crash.

[2022-12-23T04:54:59.670Z] /usr/local/bin/../include/c++/v1/vector:1580: _LIBCPP_ASSERT '__n < size()' failed. vector[] index out of bounds

Looking at it, might introduced by rebase.

mengxin9014
mengxin9014 approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@mengxin9014 mengxin9014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 23, 2022
@yibin87
Copy link
Contributor Author

yibin87 commented Dec 23, 2022

/run-all-tests

@ywqzzy
Copy link
Contributor

ywqzzy commented Dec 23, 2022

It looks like ComputeServerRunner.runFineGrainedShuffleJoinTest has had a crash.

[2022-12-23T04:54:59.670Z] /usr/local/bin/../include/c++/v1/vector:1580: _LIBCPP_ASSERT '__n < size()' failed. vector[] index out of bounds

Looking at it, might introduced by rebase.

Related issue: #6542

@yibin87
Copy link
Contributor Author

yibin87 commented Dec 23, 2022

/merge

@ti-chi-bot
Copy link
Member

@yibin87: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0448067

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 23, 2022
@ti-chi-bot
Copy link
Member

@yibin87: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 957d2d4 into pingcap:master Dec 23, 2022
@yibin87 yibin87 mentioned this pull request Dec 23, 2022
Closed
6 tasks
@yibin87 yibin87 mentioned this pull request Aug 3, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy approved these changes

@mengxin9014 mengxin9014 mengxin9014 approved these changes

@SeaRise SeaRise Awaiting requested review from SeaRise

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yibin87 @ti-chi-bot @SeaRise @ywqzzy @mengxin9014