storage: add more store statistics #6038
Conversation
Signed-off-by: Wish <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
added
the
size/XXL
| namespace DM | ||
| { | ||
|
|
||
| static inline DB::PS::V2::PageEntriesVersionSetWithDelta::Snapshot * |
There was a problem hiding this comment.
Can we use auto as return type here?
| } | ||
| else | ||
| { | ||
| LOG_FMT_ERROR(log, "Can't get any version from current snapshot, type=data"); |
There was a problem hiding this comment.
maybe use LOG_XXX instead of LOG_FMT_XXX, we will remove all LOG_FMT_XXX later.
| const auto * concrete_snap = toConcreteSnapshot(log_snapshot); | ||
| if (concrete_snap) |
There was a problem hiding this comment.
maybe combine the two lines.
if (const auto * concrete_snap = toConcreteSnapshot(log_snapshot); concrete_snap)
Signed-off-by: Wish <[email protected]>
|
/merge |
|
@breezewish: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: b8f3bad
|
ti-chi-bot
added
the
status/can-merge
|
@breezewish: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
In response to a cherrypick label: new pull request created: #6079. |
What problem does this PR solve?
Issue Number: ref #5975
Problem Summary: In #5975 we discovered a GC issue that is related with logical split. In order to make life easier when debugging such issues, we can enhance and provide more information in the system table.
What is changed and how it works?
Moved
DeltaMergeStore::getStatto beDeltaMergeStore::getStoreStatsinDeltaMergeStore_Statistics.cpp. The items of statistics are not changed.Added some statistics items to
DeltaMergeStore::getSegmentsStats.Note: As we have removed some fields in this PR, during upgrading the TIFLASH_SEGMENTS table will be not queryable. This problem has been resolved in pingcap/tidb#38191 so that in future when we have other field removals no error will be thrown.
Check List
Tests
Manually tested with
SELECT * FROM INFORMATION_SCHEMA.TIFLASH_SEGMENTS.New TiFlash + New TiDB
Old TiFlash + New TiDB
Old TiDB + New TiFlash (This happens during upgrading)
Side effects
Documentation
Release note