Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use readable pathname in DMFileReader #5958

Merged
merged 6 commits into from
Sep 21, 2022
Merged

Always use readable pathname in DMFileReader #5958

merged 6 commits into from
Sep 21, 2022

Conversation

JinheLin
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #5956

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.3 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2022
@JinheLin
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang
Copy link
Contributor

/run-sanitizer-test tsan

@JaySon-Huang
Copy link
Contributor

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 20, 2022

Coverage for changed files

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DMFileBlockInputStream.cpp          46                33    28.26%           2                 0   100.00%          43                 1    97.67%          12                 3    75.00%
DMFileReader.h                      10                 0   100.00%           4                 0   100.00%          10                 0   100.00%           4                 0   100.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                               56                33    41.07%           6                 0   100.00%          53                 1    98.11%          16                 3    81.25%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18862      8119             56.96%    219537  83635        61.90%

full coverage report (for internal network access only)

@JaySon-Huang
Copy link
Contributor

https://ci.pingcap.net/blue/organizations/jenkins/tiflash-sanitizer-daily/detail/tiflash-sanitizer-daily/538/pipeline/73

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 21, 2022
@JinheLin
Copy link
Contributor Author

/run-unit-test

flowbehappy
flowbehappy approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2022
@JinheLin
Copy link
Contributor Author

/run-all-tests

JaySon-Huang
JaySon-Huang approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 21, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3bc77f9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@ti-chi-bot
Copy link
Member

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JaySon-Huang
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@JinheLin
Copy link
Contributor Author

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 21, 2022

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
File/DMFileBlockInputStream.cpp            46                33    28.26%           2                 0   100.00%          43                 1    97.67%          12                 3    75.00%
File/DMFileReader.h                        10                 0   100.00%           4                 0   100.00%          10                 0   100.00%           4                 0   100.00%
ReadThread/ColumnSharingCache.cpp          22                 3    86.36%           5                 0   100.00%          42                 8    80.95%          14                 4    71.43%
ReadThread/ColumnSharingCache.h            69                 8    88.41%          13                 2    84.62%         118                13    88.98%          30                 6    80.00%
tests/gtest_segment_reader.cpp             40                14    65.00%           2                 0   100.00%         149                 0   100.00%          10                 8    20.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                     187                58    68.98%          26                 2    92.31%         362                22    93.92%          70                21    70.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18781      7989             57.46%    219005  82437        62.36%

full coverage report (for internal network access only)

@JinheLin
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b7fd5ca

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 21, 2022

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
File/DMFileBlockInputStream.cpp            46                33    28.26%           2                 0   100.00%          43                 1    97.67%          12                 3    75.00%
File/DMFileReader.h                        10                 0   100.00%           4                 0   100.00%          10                 0   100.00%           4                 0   100.00%
ReadThread/ColumnSharingCache.cpp          22                 3    86.36%           5                 0   100.00%          42                 8    80.95%          14                 4    71.43%
ReadThread/ColumnSharingCache.h            69                 8    88.41%          13                 2    84.62%         118                13    88.98%          30                 8    73.33%
tests/gtest_segment_reader.cpp             40                14    65.00%           2                 0   100.00%         149                 0   100.00%          10                 8    20.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                     187                58    68.98%          26                 2    92.31%         362                22    93.92%          70                23    67.14%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18781      7990             57.46%    219005  82430        62.36%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 7c0472c into pingcap:master Sep 21, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5983.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2022
Merged
12 tasks
ti-chi-bot added a commit that referenced this pull request Sep 22, 2022
@ti-chi-bot
Always use readable pathname in DMFileReader (#5958) (#5983)
6a305d3 
close #5956
@JinheLin JinheLin deleted the fix-dm-file-reader-pool branch March 27, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@lidezhu lidezhu Awaiting requested review from lidezhu

@Lloyd-Pottiger Lloyd-Pottiger Awaiting requested review from Lloyd-Pottiger

@hehechen hehechen Awaiting requested review from hehechen

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.3 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concurrency between data sharing and segment compaction may leave some DMFileReader can not be removed
5 participants
@JinheLin @ti-chi-bot @JaySon-Huang @sre-bot @flowbehappy