-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update client-c to disable grpc client keepalive #4655
update client-c to disable grpc client keepalive #4655
Conversation
Signed-off-by: xufei <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@windtalker: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: b0d68f7
|
Do we plan to upgrade our grpc version? |
Yes, I think so. |
/run-integration-test |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
In response to a cherrypick label: failed to apply #4655 on top of branch "release-5.3":
|
In response to a cherrypick label: failed to apply #4655 on top of branch "release-5.4":
|
In response to a cherrypick label: failed to apply #4655 on top of branch "release-6.0":
|
In response to a cherrypick label: failed to apply #4655 on top of branch "release-5.0":
|
In response to a cherrypick label: failed to apply #4655 on top of branch "release-5.1":
|
In response to a cherrypick label: failed to apply #4655 on top of branch "release-5.2":
|
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei [email protected]
What problem does this PR solve?
Issue Number: close #4192, close #4662
Problem Summary:
TiFlash will randomly meet
keepalive watchdog fired
error.What is changed and how it works?
The root cause is the current used grpc version has a bug, and it is unavoidable to hit the keepalive timeout error under our current keepalive strategy. Keepalive is introduced in #3649 in order to fix #3615, but the root cause of #3615 is the client reconnection strategy, the related tests can pass even without keepalive, so this pr disable the grpc client keepalive.
Check List
Tests
Side effects
Documentation
Release note