Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update client-c to disable grpc client keepalive #4655

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Apr 14, 2022

Signed-off-by: xufei [email protected]

What problem does this PR solve?

Issue Number: close #4192, close #4662

Problem Summary:

TiFlash will randomly meet keepalive watchdog fired error.

What is changed and how it works?

The root cause is the current used grpc version has a bug, and it is unavoidable to hit the keepalive timeout error under our current keepalive strategy. Keepalive is introduced in #3649 in order to fix #3615, but the root cause of #3615 is the client reconnection strategy, the related tests can pass even without keepalive, so this pr disable the grpc client keepalive.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix bug that TiFlash query will meet keepalive timeout error randomly.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bestwoody
  • fzhedu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2022
@windtalker windtalker added needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 labels Apr 14, 2022
Copy link
Contributor

@bestwoody bestwoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2022
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 14, 2022
@windtalker
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b0d68f7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@JaySon-Huang
Copy link
Contributor

The root cause is the current used grpc version has a bug, and it is unavoidable to hit the keepalive timeout error under our current keepalive strategy.

Do we plan to upgrade our grpc version?

@windtalker
Copy link
Contributor Author

The root cause is the current used grpc version has a bug, and it is unavoidable to hit the keepalive timeout error under our current keepalive strategy.

Do we plan to upgrade our grpc version?

Yes, I think so.

@windtalker
Copy link
Contributor Author

/run-integration-test

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 14, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17025      9512             44.13%    191972  96460        49.75%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 989bf8d into pingcap:master Apr 14, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #4655 on top of branch "release-5.3":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #4655 on top of branch "release-5.4":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #4655 on top of branch "release-6.0":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #4655 on top of branch "release-5.0":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #4655 on top of branch "release-5.1":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #4655 on top of branch "release-5.2":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

windtalker added a commit to windtalker/tiflash that referenced this pull request Apr 14, 2022
windtalker added a commit to windtalker/tiflash that referenced this pull request Apr 14, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 14, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17025      9512             44.13%    191972  96445        49.76%

full coverage report (for internal network access only)

windtalker added a commit to windtalker/tiflash that referenced this pull request Apr 21, 2022
windtalker added a commit to windtalker/tiflash that referenced this pull request Apr 21, 2022
windtalker added a commit to windtalker/tiflash that referenced this pull request Apr 21, 2022
windtalker added a commit to windtalker/tiflash that referenced this pull request Apr 21, 2022
windtalker added a commit to windtalker/tiflash that referenced this pull request Apr 22, 2022
@windtalker windtalker deleted the disable_client_keepalive branch January 30, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
6 participants