Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ha test random failure #3649

Merged
merged 7 commits into from
Dec 15, 2021
Merged

Fix ha test random failure #3649

merged 7 commits into from
Dec 15, 2021

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Dec 15, 2021 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #3615

Problem Summary:
As the issue described.

What is changed and how it works?

Check List

Align the keep alive/reconnect configure with client go(which is used by TiDB)

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that TiFlash might return the `EstablishMPPConnection` error after it is restarted

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzhedu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2021
@windtalker
Copy link
Contributor Author

/run-all-tests

fzhedu
fzhedu approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2021
@fzhedu
Copy link
Contributor

fzhedu commented Dec 15, 2021

/merge

@ti-chi-bot
Copy link
Member

@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6879c74

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 15, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 15, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/378/cobertura/
(Coverage detail url is limited office network access)

lines: 42.3% (46971 out of 111055)
branches: 6.0% (72480 out of 1206196)

@ti-chi-bot ti-chi-bot merged commit 8463cef into pingcap:master Dec 15, 2021
@windtalker windtalker added needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 labels Dec 22, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 22, 2021
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#3649
dc05a19 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 22, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3705.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 22, 2021
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#3649
a997890 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 22, 2021
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#3649
a11185f 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 22, 2021
Merged
12 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 22, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3706.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3707.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 22, 2021
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#3649
1ef2d50 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 22, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3708.

@windtalker windtalker deleted the fix_ha_fail branch January 11, 2022 09:39
ti-chi-bot added a commit that referenced this pull request Jan 26, 2022
@ti-chi-bot
Fix ha test random failure (#3649) (#3707)
31dab71
ti-chi-bot added a commit that referenced this pull request Apr 14, 2022
@ti-chi-bot
Fix ha test random failure (#3649) (#3705)
a849a50 
close #3615
@windtalker windtalker mentioned this pull request Apr 14, 2022
Merged
12 tasks
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 20, 2022

lines: 41.9% (46967 out of 112154)
branches: 6.0% (72468 out of 1207710)

ti-chi-bot added a commit that referenced this pull request Jun 15, 2022
@ti-chi-bot
Fix ha test random failure (#3649) (#3708)
168a3a8 
close #3615
windtalker added a commit to ti-chi-bot/tiflash that referenced this pull request Jun 16, 2022
@windtalker
This is an automated cherry-pick of pingcap#3649
51fbba4 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot added a commit that referenced this pull request Jun 16, 2022
@ti-chi-bot
Fix ha test random failure (#3649) (#3706)
5791e0a 
close #3615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhedu fzhedu fzhedu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The high availability case failed for that it raise mpp timeout after tiflash node start for a while
4 participants
@windtalker @ti-chi-bot @fzhedu @sre-bot