Fix create table error (#4630)

[ti-chi-bot]

This is an automated cherry-pick of #4630

What problem does this PR solve?

Issue Number: close #4596

Problem Summary:

What is changed and how it works?

make sure Flen >= 0 before append.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang
• flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[Lloyd-Pottiger]

/run-integration-test

[Lloyd-Pottiger]

/cc @JaySon-Huang @flowbehappy

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 2cc0e57

[Lloyd-Pottiger]

/merge

[ti-chi-bot]

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[JaySon-Huang]

/hold

fmtlib is not introduced into tiflash in the release-5.1 branch. You need to rewrite the test by stringstream :( @Lloyd-Pottiger

[2022-09-20T03:31:08.080Z] /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Databases/test/gtest_database.cpp: In member function 'virtual void DB::tests::DatabaseTiFlash_test_ISSUE4596_Test::TestBody()':
[2022-09-20T03:31:08.080Z] /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Databases/test/gtest_database.cpp:653:29: error: 'fmt' has not been declared
[2022-09-20T03:31:08.080Z]          const String stmt = fmt::format("CREATE TABLE `{}`.`{}` ", db_name, tbl_name) +

[Lloyd-Pottiger]

fmtlib is not introduced into tiflash in the release-5.1 branch. You need to rewrite the test by stringstream :( @Lloyd-Pottiger

ok

[Lloyd-Pottiger]

/run-unit-test

[Lloyd-Pottiger]

/unhold

[Lloyd-Pottiger]

/merge

[ti-chi-bot]

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.