Fix create table error

[Lloyd-Pottiger]

What problem does this PR solve?

Issue Number: close #4596

Problem Summary:

What is changed and how it works?

make sure Flen >= 0 before append.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang
• ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[Lloyd-Pottiger]

Two remaining problems:

1. do we need to support unsigned data type?
2. for the TODO in case TypeBit {}, the current behavior is in line with expectations.

[Lloyd-Pottiger]

/run-all-tests

[Lloyd-Pottiger]

/run-unit-test

[Lloyd-Pottiger]

/run-unit-test

[Lloyd-Pottiger]

/run-unit-test

[sre-bot]

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Databases/test/gtest_database.cpp        2256               393    82.58%          19                 0   100.00%         666                 8    98.80%         722               368    49.03%
Storages/Transaction/TiDB.cpp             478               264    44.77%          45                13    71.11%         844               385    54.38%         334               148    55.69%
Storages/Transaction/TiDB.h                20                 7    65.00%          16                 3    81.25%          16                 3    81.25%           6                 6     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    2754               664    75.89%          80                16    80.00%        1526               396    74.05%        1062               522    50.85%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17021      9515             44.10%    191865  96430        49.74%

full coverage report (for internal network access only)

[Lloyd-Pottiger]

/cc @JaySon-Huang

[ti-chi-bot]

@Lloyd-Pottiger: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[sre-bot]

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Databases/test/gtest_database.cpp        2256               393    82.58%          19                 0   100.00%         729                 8    98.90%         722               368    49.03%
Storages/Transaction/TiDB.cpp             478               264    44.77%          45                13    71.11%         844               385    54.38%         334               148    55.69%
Storages/Transaction/TiDB.h                20                 7    65.00%          16                 3    81.25%          16                 3    81.25%           6                 6     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    2754               664    75.89%          80                16    80.00%        1589               396    75.08%        1062               522    50.85%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17025      9512             44.13%    191976  96458        49.76%

full coverage report (for internal network access only)

[JaySon-Huang]

/rebuild

[JaySon-Huang]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Databases/test/gtest_database.cpp        2256               393    82.58%          19                 0   100.00%         729                 8    98.90%         722               368    49.03%
Storages/Transaction/TiDB.cpp             478               264    44.77%          45                13    71.11%         844               385    54.38%         334               148    55.69%
Storages/Transaction/TiDB.h                20                 7    65.00%          16                 3    81.25%          16                 3    81.25%           6                 6     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    2754               664    75.89%          80                16    80.00%        1589               396    75.08%        1062               522    50.85%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17025      9512             44.13%    191978  96456        49.76%

full coverage report (for internal network access only)

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #4649.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #4650.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #4651.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #4652.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #4653.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #4654.