Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable stacktrace related test for sanitized UT #4463

Merged
merged 5 commits into from
Mar 28, 2022
Merged

disable stacktrace related test for sanitized UT #4463

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
125cc39
disable sanitizing for stacktrace related UT
SchrodingerZhu Mar 28, 2022
26a36bf
disable UT for sanitizing
SchrodingerZhu Mar 28, 2022
674993b
undo extra change
SchrodingerZhu Mar 28, 2022
d5e0091
typo
SchrodingerZhu Mar 28, 2022
162e9f2
typo
SchrodingerZhu Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions dbms/src/Common/tests/gtest_stacktrace.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
// limitations under the License.

#include <Common/StackTrace.h>
#include <common/defines.h>
#include <gtest/gtest.h>

#include <thread>
Expand All @@ -21,7 +22,7 @@ namespace DB
{
namespace tests
{
GTEST_NO_INLINE_ void function_0(bool output = false)
NO_INLINE void function_0(bool output = false)
{
auto res = StackTrace().toString();
std::string::size_type idx;
Expand All @@ -36,7 +37,7 @@ GTEST_NO_INLINE_ void function_0(bool output = false)
idx = res.find("function_2", idx);
EXPECT_NE(idx, std::string::npos);
}
GTEST_NO_INLINE_ void function_1(bool output = false, size_t level = 0)
NO_INLINE void function_1(bool output = false, size_t level = 0)
{
if (level == 0)
{
Expand All @@ -47,10 +48,15 @@ GTEST_NO_INLINE_ void function_1(bool output = false, size_t level = 0)
function_1(output, level - 1);
}
}
GTEST_NO_INLINE_ void function_2(bool output = false, size_t level = 0)
NO_INLINE void function_2(bool output = false, size_t level = 0)
{
function_1(output, level);
}

// Sanitizers wrongly report info on the rust side and they may mess up the stacktrace.
// Setting no_sanitize does not fix the issue.
// we skip the stacktrace tests for TSAN
#if !defined(THREAD_SANITIZER) && !defined(ADDRESS_SANITIZER)
TEST(StackTrace, SingleThread)
{
function_2(true);
Expand All @@ -74,5 +80,7 @@ TEST(StackTrace, MultiThreads)
i.join();
}
}
#endif

} // namespace tests
} // namespace DB